> -----Original Message----- > From: Jan Beulich [mailto:[email protected]] > Sent: 04 September 2018 11:38 > To: Paul Durrant <[email protected]> > Cc: Julien Grall <[email protected]>; Andrew Cooper > <[email protected]>; Wei Liu <[email protected]>; George > Dunlap <[email protected]>; Ian Jackson <[email protected]>; > Jun Nakajima <[email protected]>; Kevin Tian > <[email protected]>; Stefano Stabellini <[email protected]>; xen- > devel <[email protected]>; Konrad Rzeszutek Wilk > <[email protected]>; Tim (Xen.org) <[email protected]> > Subject: Re: [PATCH v6 04/14] iommu: don't domain_crash() inside > iommu_map/unmap_page() > > >>> On 23.08.18 at 11:47, <[email protected]> wrote: > > --- a/xen/common/grant_table.c > > +++ b/xen/common/grant_table.c > > @@ -1154,6 +1154,7 @@ map_grant_ref( > > } > > if ( err ) > > { > > + domu_crash(ld); > > double_gt_unlock(lgt, rgt); > > You crash the domain with both locks held here, but ... > > > @@ -1406,7 +1407,10 @@ unmap_common( > > double_gt_unlock(lgt, rgt); > > > > if ( err ) > > + { > > + domu_crash(ld); > > rc = GNTST_general_error; > > + } > > ... outside of the locked region here. I think the latter is fine, and > hence the former should be changed.
Sure. Will do. > > With that > Reviewed-by: Jan Beulich <[email protected]> > Thanks, Paul > Jan > _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
