> From: Andrew Cooper [mailto:[email protected]] > Sent: Thursday, August 30, 2018 11:47 PM > > On 30/08/18 15:54, Jan Beulich wrote: > >>>> On 28.08.18 at 19:39, <[email protected]> wrote: > >> The suffix and prefix are redundant, and the name is curiously odd. > Rename it > >> to vmx_vcpu to be consistent with all the other similar structures. > >> > >> No functional change. > >> > >> Signed-off-by: Andrew Cooper <[email protected]> > >> --- > >> CC: Jan Beulich <[email protected]> > >> CC: Wei Liu <[email protected]> > >> CC: Roger Pau Monné <[email protected]> > >> CC: Jun Nakajima <[email protected]> > >> CC: Kevin Tian <[email protected]> > >> > >> Some of the local pointers are named arch_vmx. I'm open to renaming > them to > >> just vmx (like all the other local pointers) if people are happy with the > >> additional patch delta. > > I'd be fine with that. With or without > > Acked-by: Jan Beulich <[email protected]> > > TBH, I was hoping for a comment from Kevin on this question. > > Given that the net diffstat including the pointer renames is: > > andrewcoop@andrewcoop:/local/xen.git/xen$ git d HEAD^ --stat > xen/arch/x86/hvm/vmx/vmcs.c | 44 > ++++++++++++++++++++++---------------------- > xen/arch/x86/hvm/vmx/vmx.c | 4 ++-- > xen/include/asm-x86/hvm/vcpu.h | 2 +- > xen/include/asm-x86/hvm/vmx/vmcs.h | 2 +- > 4 files changed, 26 insertions(+), 26 deletions(-) > > I've decided to go ahead and do them, to improve the eventual code > consistency.
yes, please go ahead. I didn't note that open earlier. Thanks Kevin _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
