The structure already has explicitly padding.
Removing the attribute silences a clang 6 warning:
tcgbios.c:1519:34: error: taking address of packed member 'u' of class or
structure 'pushad_regs_t' may result in an unaligned pointer value
[-Werror,-Waddress-of-packed-member]
®s->u.r32.edx);
^~~~~~~~~~~~~~~
Signed-off-by: Wei Liu <[email protected]>
---
tools/firmware/rombios/32bit/rombios_compat.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/firmware/rombios/32bit/rombios_compat.h
b/tools/firmware/rombios/32bit/rombios_compat.h
index c0ae4151b5..3fe7d67721 100644
--- a/tools/firmware/rombios/32bit/rombios_compat.h
+++ b/tools/firmware/rombios/32bit/rombios_compat.h
@@ -52,7 +52,7 @@ typedef struct {
Bit16u filler4;
} r8;
} u;
-} __attribute__((packed)) pushad_regs_t;
+} pushad_regs_t;
--
2.11.0
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
