On Tue, 14 Aug 2018, Julien Grall wrote: > Hi Stefano, > > On 08/14/2018 09:46 PM, Stefano Stabellini wrote: > > On Mon, 16 Jul 2018, Julien Grall wrote: > > > A couple of places in the code will need to clear/set flags in HCR_EL2 > > > for a given vCPU and then replicate into the hardware. Introduce > > > helpers and replace open-coded version. > > > > > > Signed-off-by: Julien Grall <[email protected]> > > > > The macros look good, but I grepped for them in your series and there > > are no more callers. What places are you referring to that they will > > need them? > > I split some of my work in 2 part to reduce the size of the series. This will > be used in another series where updating HCR for trapping TTBR/SCTLR* will be > dynamic. > > Although in general, this is an improvement compare to the current code as it > makes clear what needs to be updated when modifying HCR.
Yes, it is, but normally I would only introduce vcpu_hcr_set_flags in this series, because vcpu_hcr_clear_flags is left completely unused? I also don't mind introducing it anyway if you have a series coming. _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
