On Wed, Aug 01, 2018 at 10:25:22AM -0400, Jason Andryuk wrote: > On Mon, Jul 30, 2018 at 11:56 PM, Marek Marczykowski-Górecki > <[email protected]> wrote: > > From: Eric Shelton <[email protected]> > > > > This patch creates an appropriate command line for the QEMU instance > > running in a Linux-based stubdomain. > > > > NOTE: a number of items are not currently implemented for Linux-based > > stubdomains, such as: > > - save/restore > > - QMP socket > > - graphics output (e.g., VNC) > > > > Signed-off-by: Eric Shelton <[email protected]> > > > > Simon: > > * fix disk path > > * fix cdrom path and "format" > > * pass downscript for network interfaces > > --- > <snip> > > @@ -1099,10 +1118,21 @@ static int > > libxl__build_device_model_args_new(libxl__gc *gc, > > return ERROR_INVAL; > > } > > if (b_info->u.hvm.serial) { > > - flexarray_vappend(dm_args, > > - "-serial", b_info->u.hvm.serial, NULL); > > + if (is_stubdom) { > > + flexarray_vappend(dm_args, > > + "-serial", > > + GCSPRINTF("/dev/hvc%d", > > STUBDOM_CONSOLE_SERIAL), > > + NULL); > > + } else { > > + flexarray_vappend(dm_args, > > + "-serial", b_info->u.hvm.serial, > > NULL); > > + } > > } else if (b_info->u.hvm.serial_list) { > > char **p; > > + if (is_stubdom) { > > + flexarray_vappend(dm_args, > > + "-serial", "/dev/hvc1", NULL); > > Should this also be GCSPRINTF("/dev/hvc%d", STUBDOM_CONSOLE_SERIAL) > instead of hardcoding hvc1?
Yes. Anyway, multiple serial consoles are incompatible with
stubdomain anyway - should it error out if serial_list have multiple
elements? Or silently ignore others?
> > + }
> > for (p = b_info->u.hvm.serial_list;
> > *p;
> > p++) {
>
> <snip>
>
> > @@ -1550,8 +1584,8 @@ static int
> > libxl__build_device_model_args_new(libxl__gc *gc,
> >
> > if (disks[i].is_cdrom) {
> > drive = libxl__sprintf(gc,
> > -
> > "if=ide,index=%d,readonly=on,media=cdrom,id=ide-%i",
> > - disk, dev_number);
> > + "if=ide,readonly=on,media=cdrom,id=ide-%i",
> > + dev_number);
>
> What is the impact of dropping index?
Leftover from Qubes-specific part of this patch (non-cdrom disks are
converted to SCSI for readonly support, dropping index avoids hitting
IDE limitation of 4 disks). I'll remove this chunk.
> > if (target_path)
> > drive = libxl__sprintf(gc, "%s,file=%s,format=%s",
>
> Regards,
> Jason
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
signature.asc
Description: PGP signature
_______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
