> On 3 Mar 2026, at 14:07, Jan Beulich <[email protected]> wrote: > > On 27.02.2026 11:58, Edwin Török wrote: >> --- a/tools/tests/x86_emulator/test_x86_emulator.c >> +++ b/tools/tests/x86_emulator/test_x86_emulator.c >> @@ -1100,7 +1100,7 @@ int main(int argc, char **argv) >> regs.edi = (unsigned long)res; >> rc = x86_emulate(&ctxt, &emulops); >> if ( (rc != X86EMUL_OKAY) || >> - (*res != ((0x2233445F << 2) | 2)) || >> + (*res != ((0x2233445FUL << 2) | 2)) || > > Why the L when res is an array of unsigned int? With it dropped (happy > to do so while committing):
You are right, it isn’t needed, making it unsigned is enough to avoid undefined behaviour. Best regards, —Edwin
