On 26.02.2026 18:14, Andrew Cooper wrote: > On 26/02/2026 4:28 pm, Jan Beulich wrote: >> --- a/xen/arch/arm/Makefile >> +++ b/xen/arch/arm/Makefile >> @@ -15,7 +15,9 @@ obj-$(CONFIG_HAS_ALTERNATIVE) += alterna >> obj-y += cpuerrata.o >> obj-y += cpufeature.o >> obj-y += decode.o >> -obj-y += device.o >> +device-y := device.init.o >> +device-$(CONFIG_OVERLAY_DTB) := device.o >> +obj-y += $(device-y) > > I know we've argued over this before and not come to a conclusion, but I > still firmly believe this to be an anti-pattern we should expunge. > > obj-y += $(if $(CONFIG_OVERLAY_DTB),device.o,device.init.o)
Whereas I think this one (in its adjusted form to really only accept 'y') is, firmly believing that the "lists everywhere" approach is the more readable and, more importantly, more scalable one. The form you suggest quickly gets to its limits when multiple CONFIG_* need dealing with. Jan
