On 2/16/26 5:31 PM, Jan Beulich wrote:
On 12.02.2026 17:21, Oleksii Kurochko wrote:
Introduce support for loading a Linux zImage kernel on RISC-V.
Before I look here in any detail - where would a zImage come from? I can't
spot any support for it in Linux'es arch/riscv/Makefile (whereas
arch/arm/Makefile has such).
Good point.
It is something that should be renamed as not Arm64 (Arm32 really has such
target), not RISC-V doesn't really work with zImage. They are using Image plus
Image.gz as compressed image.
Maybe it would be better to rename kernel_zimage_probe() to something more
generic kernel_image_probe().
Note that if panic() is used instead of returning an error as common code
doesn't expect to have return code and it is something that should be
done separately.
Is the "if" in this sentence a leftover from some editing of earlier
different text? I can't make sense of it. Also, which "common code" do you
mean? kernel_zimage_probe()'s sole caller does respect the return value
(handing it on).
It is about kernel_zimage_load() which is used to set:
struct kernel_info->load = kernel_zimage_load
in kernel_zimage64_probe().
and which is called (and is in common code) from:
void __init kernel_load(struct kernel_info *info)
{
ASSERT(info && info->load);
info->load(info);
}
This prepares the RISC-V port for booting Linux guests using the common
domain build infrastructure.
Again, what's "common" here? Not something x86 uses, afaict.
By "common" here I meant dom0less's common code which may use functions
from this file.
I will update that part to use more specific instead of "common".
~ Oleksii
