On 17.02.2026 12:04, Roger Pau Monné wrote: > On Mon, Feb 16, 2026 at 04:54:30PM +0100, Jan Beulich wrote: >> Nothing hypercall-related needs setting up there. Nor do we need to >> check whether the idle domain is shutting down - it never will. >> >> Signed-off-by: Jan Beulich <[email protected]> > > Acked-by: Roger Pau Monné <[email protected]>
Thanks. >> @@ -516,7 +516,8 @@ struct vcpu *vcpu_create(struct domain * >> } >> >> /* Must be called after making new vcpu visible to for_each_vcpu(). */ >> - vcpu_check_shutdown(v); >> + if ( !is_idle_domain(d) ) >> + vcpu_check_shutdown(v); > > I would possibly leave this as-is. I agree that the idle domain will > never shut down, but it's possibly best to needlessly call into > vcpu_check_shutdown() for the idle domain rather than adding the extra > conditional for the common case? I'd prefer to keep it conditional: Calling the function for the idle domain gives a wrong impression, plus it may be the only one where the shutdown lock is used for that domain. We may want to make lock init conditional in domain_create() as well (possibly with other things we needlessly do for idle or more generally system domains). > My Ack stands regardless. Thank you. Jan
