On Sat Feb 14, 2026 at 12:51 AM CET, Stefano Stabellini wrote: > - if ( op->cpuid >= nr_cpu_ids || !cpu_online(op->cpuid) ) > + if ( op->cpuid >= nr_cpu_ids || !cpu_online(op->cpuid) || > + !IS_ENABLED(CONFIG_CPUFREQ) )
Largely inconsequential here (and other places in the patch), but I think IS_ENABLED(foo) should go first in all conditional chains so that any invoked function in the OR list is skipped. It's likely in this case it doesn't matter, because cpu_onlin() is a macro that calls a static inline so the whole AST is known to the compiler, but it's trickier when there's non-obvious extern functions at play. In those cases the compiler will still make the calls because it can't know the call won't have side effects. Thus, as a matter of principle, I think IS_ENABLED() checks should always come first. Cheers, Alejandro
