On 15.02.2026 19:16, Abdelkareem Abdelsaamad wrote: > --- a/xen/arch/x86/hvm/svm/vmcb.h > +++ b/xen/arch/x86/hvm/svm/vmcb.h > @@ -336,13 +336,17 @@ typedef union > u64 tpr: 8; > u64 irq: 1; > u64 vgif: 1; > - u64 rsvd0: 6; > + u64 rsvd0: 1; > + u64 vnmi_pending: 1; > + u64 vnmi_blocking:1; > + u64: 3;
Can we have a blank please ahead of the colon, to make it a little easier to actually notice? Further for both rsvd0 and ... > u64 prio: 4; > u64 ign_tpr: 1; > u64 rsvd1: 3; > u64 intr_masking: 1; > u64 vgif_enable: 1; > - u64 rsvd2: 6; > + u64 vnmi_enable: 1; > + u64 rsvd2: 5; > u64 vector: 8; > u64 rsvd3: 24; > } fields; ... rsvd2 (i.e. the ones you touch anyway) I wonder if their identifiers couldn't be dropped at this occasion as well. Jan
