On 13/02/2026 10:44 pm, Abdelkareem Abdelsaamad wrote:
> diff --git a/xen/arch/x86/include/asm/hvm/hvm.h
> b/xen/arch/x86/include/asm/hvm/hvm.h
> index 7d9774df59..ad17ea73e9 100644
> --- a/xen/arch/x86/include/asm/hvm/hvm.h
> +++ b/xen/arch/x86/include/asm/hvm/hvm.h
> @@ -115,7 +115,9 @@ struct hvm_function_table {
> virtual_intr_delivery:1,
>
> /* Nested virt capabilities */
> - nested_virt:1;
> + nested_virt:1,
> + /* virtual NMI support */
> + vNMI:1;
> } caps;
As said previously, vNMI is local to SVM, and needs to not touch common
HVM logic.
Specifically, delete this vNMI boolean and all 3 hooks you add in the
next patch (i.e. all changes to hvm.h). They're all layering violations.
~Andrew