On 06.02.2026 17:15, Alejandro Vallejo wrote:
> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -328,7 +328,11 @@ void __init early_cpu_init(bool verbose)
> *(u32 *)&c->x86_vendor_id[4] = edx;
>
> c->x86_vendor = x86_cpuid_lookup_vendor(ebx, ecx, edx);
> - switch (c->x86_vendor) {
> + if ( c->x86_vendor != cpu_vendor() )
When we introduce new functions to Linux-style files, nowadays we take
the liberty and make them Xen-style right away. In entirely Linux-
style functions the style should remain consistently Linux'es, though.
> + panic("CPU vendor not compiled-in: %s",
> + x86_cpuid_vendor_to_str(c->x86_vendor));
This will be somewhat awkward when c->x86_vendor is UNKNOWN.
There'll also be a degenerate case, but I'll comment on that on the
earlier patch causing that.
> --- a/xen/arch/x86/include/asm/cpufeature.h
> +++ b/xen/arch/x86/include/asm/cpufeature.h
> @@ -14,6 +14,7 @@
> #include <asm/cpu-policy.h>
> #include <asm/cpuid.h>
> #include <xen/lib/x86/cpu-policy.h>
> +#include <asm/x86-vendors.h>
Nit: Can the asm/-s please all stay together?
Jan
