Re: [PATCH v3 08/16] xen/riscv: introduce basic vtimer infrastructure for guests

[Oleksii Kurochko]

On 2/11/26 3:51 PM, Jan Beulich wrote:

On 09.02.2026 17:52, Oleksii Kurochko wrote:

@@ -105,11 +106,14 @@ int arch_vcpu_create(struct vcpu *v)
      if ( is_idle_vcpu(v) )
          return rc;

+ if ( (rc = vcpu_vtimer_init(v)) )

+        goto fail;
+
      /*
-     * As the vtimer and interrupt controller (IC) are not yet implemented,
+     * As interrupt controller (IC) is not yet implemented,
       * return an error.
       *
-     * TODO: Drop this once the vtimer and IC are implemented.
+     * TODO: Drop this once IC is implemented.
       */
      rc = -EOPNOTSUPP;
      goto fail;

Shouldn't you then also call vcpu_vtimer_destroy() from arch_vcpu_destroy()?

Yes, it should be.

Thanks.

~ Oleksii