On 05.02.2026 02:36, [email protected] wrote: > From: Denis Mukhin <[email protected]> > > Both conring{,_size} should be RO after initialization is completed. > > Suggested-by: Andrew Cooper <[email protected]> > Signed-off-by: Denis Mukhin <[email protected]>
Ah yes, that's one of those things mentioned for patch 1. Acked-by: Jan Beulich <[email protected]> preferably with ... > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -346,8 +346,8 @@ size_param("conring_size", opt_conring_size); > #define _CONRING_SIZE (1U << CONFIG_CONRING_SHIFT) > #define CONRING_IDX_MASK(i) ((i) & (conring_size - 1)) > static char __initdata _conring[_CONRING_SIZE]; > -static char *__read_mostly conring = _conring; > -static uint32_t __read_mostly conring_size = _CONRING_SIZE; > +static char *__ro_after_init conring = _conring; > +static uint32_t __ro_after_init conring_size = _CONRING_SIZE; ... the type here also changed to unsigned int (as set forth by ./CODING_STYLE). Happy to adjust while committing. Jan
