On 09.02.2026 16:44, Roger Pau Monné wrote: > On Mon, Feb 09, 2026 at 11:31:15AM +0100, Alejandro Vallejo wrote: >> --- a/xen/arch/x86/mm/paging.c >> +++ b/xen/arch/x86/mm/paging.c >> @@ -623,10 +623,12 @@ int paging_domain_init(struct domain *d) >> INIT_PAGE_LIST_HEAD(&d->arch.paging.freelist); >> mm_lock_init(&d->arch.paging.lock); >> >> +#ifdef CONFIG_LOG_DIRTY >> /* This must be initialized separately from the rest of the >> * log-dirty init code as that can be called more than once and we >> * don't want to leak any active log-dirty bitmaps */ >> d->arch.paging.log_dirty.top = INVALID_MFN; >> +#endif /* CONFIG_LOG_DIRTY */ > > Could you possibly init this field from paging_log_dirty_init()? As > to avoid having more ifdef churn in paging_domain_init().
Hmm, I was wondering the same, but then trusted the comment. Looks like it may be stale, though. Jan
