Hi Jan, > On 4 Feb 2026, at 16:31, Jan Beulich <[email protected]> wrote: > > On 04.02.2026 14:16, Bertrand Marquis wrote: >> Xen does not currently document how to build the hypervisor on macOS, and >> there is no Darwin configuration for a Homebrew-based toolchain. In >> addition, the Makefile silent-mode detection can be tripped by -I paths >> that contain an "s", which hides build commands unexpectedly. > > This wants submitting as a standalone fix, so it can be backported. But see > also below. I don't, however, understand how -I could be useful here - our > build system is self-contained, so any include directives used should be > satisfiable without any -I.
This is added automatically inside our Makefile if you build out of tree: MAKEFLAGS += --include-dir=$(abs_srctree) which ends up being -Ixxx when tested. I was not thinking as this being a candidate for backport as the only consequence is that if you have a s in the full path to the xen tree your build will be silent even if you pass V=1 or Q= to make but things will still build. But i will split that as a standalone patch. > >> --- /dev/null >> +++ b/config/Darwin.mk >> @@ -0,0 +1,4 @@ >> +include $(XEN_ROOT)/config/StdGNU.mk > > Darwin isn't really a GNU environment, is it? The definitions in that file > may be suitable, but perhaps a brief comment is warranted? Yes this is only valid because we use brew in that case. I will add a comment. > >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -116,7 +116,7 @@ endif >> # If the user is running make -s (silent mode), suppress echoing of >> # commands >> >> -ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),) >> +ifneq ($(findstring s,$(firstword $(MAKEFLAGS))),) > > While probably this would do, assuming make isn't going to make drastic > changes to how $(MAKEFLAGS) is set up, how about > > -ifneq ($(findstring s,$(filter-out -%,$(MAKEFLAGS))),) > > instead? Yes this is a solution that should work to, making the assumption that short arguments are kept at the beginning like they are now is possibly to strong. I will test and check that and submit submit 2 independent patches. Cheers Bertrand > > Jan
