On 07.01.2026 16:58, Anthony PERARD wrote: > On Fri, Dec 19, 2025 at 03:42:17PM +0000, Teddy Astie wrote: >> --- a/tools/misc/Makefile >> +++ b/tools/misc/Makefile >> @@ -23,13 +23,13 @@ INSTALL_SBIN-$(CONFIG_X86) += xen-lowmemd >> INSTALL_SBIN-$(CONFIG_X86) += xen-mceinj >> INSTALL_SBIN-$(CONFIG_X86) += xen-memshare >> INSTALL_SBIN-$(CONFIG_X86) += xen-mfndump >> +INSTALL_SBIN-$(CONFIG_X86) += xenpm > > Nit: I would sort this by taking the dash `-` into account since we do > so for the arch-common list, so xenpm would go after xen-vmtrace.
Not really; imo it's coincidental that all present x86-only ones have a dash. I think this simply wants to ... >> INSTALL_SBIN-$(CONFIG_X86) += xen-ucode >> INSTALL_SBIN-$(CONFIG_X86) += xen-vmtrace >> INSTALL_SBIN += xencov >> INSTALL_SBIN += xenhypfs >> INSTALL_SBIN += xenlockprof >> INSTALL_SBIN += xenperf >> -INSTALL_SBIN += xenpm ... stay in its present place, merely becoming conditional. >> INSTALL_SBIN += xenwatchdogd >> INSTALL_SBIN += xen-access >> INSTALL_SBIN += xen-livepatch The three entries with dashes quite likely were blindly added to the tail, without paying attention to sorting. Imo they want moving up into their respective positions. Jan
