[Public]

> -----Original Message-----
> From: Jan Beulich <[email protected]>
> Sent: Wednesday, November 26, 2025 5:21 PM
> To: Penny, Zheng <[email protected]>
> Cc: Huang, Ray <[email protected]>; [email protected]; Andrew
> Cooper <[email protected]>; Roger Pau MonnĂ© <[email protected]>;
> [email protected]
> Subject: Re: [PATCH v4 22/24] xen/domctl: domctl_lock synchronization only 
> when
> MGMT_HYPERCALLS=y
>
> On 21.11.2025 11:57, Penny Zheng wrote:
> > Helper domctl_lock_{acquire,release} is domctl_lock, which
> > HVM_PARAM_IDENT_PT uses to ensure synchronization on potential domctl-op
> altering guest state.
> > So it is only needed when MGMT_HYPERCALLS=y.
> >
> > Suggested-by: Jan Beulich <[email protected]>
> > Signed-off-by: Penny Zheng <[email protected]>
>
> Acked-by: Jan Beulich <[email protected]>

Thx

>
> I'd like to note though that ...
>
> > ---
> > v3 -> v4:
> > - new commit
> > ---
> >  xen/arch/x86/hvm/hvm.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
>
> ... with this diffstat the subject prefix is pretty misleading once again. I 
> may take
> the liberty and convert it to x86/hvm: (and then also add parentheses to
> domctl_lock()).
>

Will fix

> Jan

Reply via email to