On 27.11.2025 15:27, Anthony PERARD wrote: > On Tue, Nov 25, 2025 at 10:11:21AM +0100, Jan Beulich wrote: >> Ideally internal function declarations wouldn't live in a non-private >> header. If already they need to, they should be hidden as much as >> possible. That is (a) their declarations shouldn't be exposed and (b) the >> symbols shouldn't appear in the shared library's dynamic symbol table. >> Gate the declarations upon _hidden actually being defined (rather than >> providing an empty fallback), and apply _hidden also to the libyail >> variants. > > The YAJL functions needs to stay in the API, they've been exposed on > purpose in this header... The only user of those I know is `xl`. They > are limited since your application also needs to use libyajl. I think > I've butchered this header enough to make it complicated to use for > applications that are not `xl`.
But xl doesn't use any of them, ... > libxl_json.h is only part of the header, there's a second part that is > automatically generated, _libxl_types_json.h. ... it only uses something from that generated header (which isn't being altered here). Jan
