On 27.11.2025 14:39, Teddy Astie wrote: > This function can only be reached from EPT-related code which is inherently > HAP. Thus it is not useful to check for shadow_paging (or lack of HAP) there. > > Moreover, it is an error to call this function in the non-EPT cases. > > Not a functional change. > > Signed-off-by: Teddy Astie <[email protected]>
Reviewed-by: Jan Beulich <[email protected]> > --- > This function is only called through EPT code and by vmx_domain_update_eptp() > called by EPT log-dirty logic, and doesn't look reachable from shadow paging > code. > > I think the original reason of this check was for eventually allowing guests > to > use both shadow paging and HAP and switch between the 2 dynamically. I don't think there ever was such a plan. The function originally lived in vmx.c, and there - even if just as a safeguard - having the extra check may have made sense. Jan
