On 05.11.2025 12:33, Oleksii Kurochko wrote: > > On 10/30/25 1:10 PM, Jan Beulich wrote: >> Arm's arch_domain_soft_reset() returning -ENOSYS is quite unhelpful: This >> way a domain will be crashed if a tool stack mistakenly invokes >> XEN_DOMCTL_soft_reset on it. Instead the tool stack should be told of its >> mistake. >> >> Introduce HAS_SOFT_RESET, implied only by x86. "imply" rather than >> "select" such that HAS_SOFT_RESET can later gain a dependency on >> MGMT_HYPERCALLS. That way HAS_SOFT_RESET will go off when >> MGMT_HYPERCALLS is off. >> >> Check the new setting early in domctl handling, and compile out the thus >> dead (when HAS_SOFT_RESET=n) domain_soft_reset() as well as its dedicated >> helpers. >> >> Signed-off-by: Jan Beulich<[email protected]> > > LGTM: > > Reviewed-by: Oleksii Kurochko<[email protected]>
Thanks, but one remark: Here as well as in your release-acks, can you please get used to inserting a blank ahead of the opening angle bracket? Roger had asked (me, not you) about its absence too, the other day. Jan
