On Fri, Oct 24, 2025 at 05:00:34PM +0100, Andrew Cooper wrote: > On 24/10/2025 4:58 pm, Andrew Cooper wrote: > > On 24/10/2025 4:13 pm, Frediano Ziglio wrote: > >> If a SR-IOV card presents an I/O space inside a BAR the > >> code will continue to loop on the same card. > >> This is due to the missing increment of the cycle variable. > >> > >> Signed-off-by: Frediano Ziglio <[email protected]> > > Yes, that's buggy. Was this from a real card, or just code inspection? > > Sorry, sent too early. > > This was broken by a1a6d59862f4 ("pci: split code to size BARs from > pci_add_device") when it changed the loop from having an increment, to not.
That was my fault. Reviewed-by: Roger Pau Monné <[email protected]> I think we want to consider, this for 4.21, what's your opinion Oleksii? Thanks, Roger.
