On 23.10.2025 01:21, Stefano Stabellini wrote:
> Fix a few randconfig build breakages that started appearing after the
> SYSCTL patch series.
>
> First, reintroduce depends on !PV_SHIM_EXCLUSIVE for HVM, as it was
> before 568f806cba4c.
>
> Also, add depends on !PV_SHIM_EXCLUSIVE for SYSCTL, that way the
> behavior goes back to what it was before 34317c508294.
>
> Fixes: 568f806cba4c ("xen/x86: remove "depends on !PV_SHIM_EXCLUSIVE"")
> Fixes: 34317c508294 ("xen/sysctl: wrap around sysctl hypercall")
> Signed-off-by: Stefano Stabellini <[email protected]>
As before, while ...
> --- a/xen/arch/x86/hvm/Kconfig
> +++ b/xen/arch/x86/hvm/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig HVM
> bool "HVM support"
> + depends on !PV_SHIM_EXCLUSIVE
> default !PV_SHIM
> select COMPAT
> select IOREQ_SERVER
... this indeed is a straight (partial) revert of one of the two named
commits, ...
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -653,6 +653,7 @@ menu "Supported hypercall interfaces"
>
> config SYSCTL
> bool "Enable sysctl hypercall"
> + depends on !PV_SHIM_EXCLUSIVE
> default y
> help
> This option shall only be disabled on some dom0less systems, or
... this isn't when imo it should be. It has a benefit, though: Despite
being just a partial revert, it prevents sysctl.o from being built into
the shim binary. On that basis:
Acked-by: Jan Beulich <[email protected]>
Jan
