On 07.10.25 12:21, Peter Zijlstra wrote:
On Tue, Oct 07, 2025 at 09:47:48AM +0200, Jürgen Groß wrote:
On 06.10.25 20:55, Peter Zijlstra wrote:
On Mon, Oct 06, 2025 at 09:46:00AM +0200, Juergen Gross wrote:
Instead of having a pre-filled array xen_irq_ops for Xen PV paravirt
functions, drop the array and assign each element individually.

Same comment for the next few patches; this changelog is a little light
on *why*. I mean, I don't mind the change, but supposedly we should
justify things at least a little, right? :-)

Would you be fine with the following addition:

   This is in preparation of reducing the paravirt include hell by
   splitting paravirt.h into multiple more fine grained header files,
   which will in turn require to split up the pv_ops vector as well.
   Dropping the pre-filled array makes life easier for objtool to
   detect missing initializers in multiple pv_ops_ arrays.

Yes, that'll do. The latter being the main reason in this case, right?
Yes.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to