On 13.10.2025 09:45, Jiqian Chen wrote:
> @@ -2031,7 +2032,7 @@ static void pci_remove_detached(libxl__egc *egc,
> }
>
> for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) {
> - if (fscanf(f, "0x%x 0x%x 0x%x\n", &start, &end, &flags) != 3)
> + if (fscanf(f, "0x%"SCNx64" 0x%"SCNx64" 0x%"SCNx64"\n", &start, &end,
> &flags) != 3)
This line has now grown too long, where it can easily be wrapped (unlike ...
> @@ -2040,7 +2041,7 @@ static void pci_remove_detached(libxl__egc *egc,
> size, 0);
> if (rc < 0)
> LOGED(ERROR, domid,
> - "xc_domain_ioport_permission error 0x%x/0x%x",
> + "xc_domain_ioport_permission error
> %#"PRIx64"/%#"PRIx64,
... here and ...
> @@ -2050,7 +2051,7 @@ static void pci_remove_detached(libxl__egc *egc,
> 0);
> if (rc < 0)
> LOGED(ERROR, domid,
> - "xc_domain_iomem_permission error 0x%x/0x%x",
> + "xc_domain_ioport_permission error
> %#"PRIx64"/%#"PRIx64,
... here, where we prefer to keep the entire format string on a single line).
Can likely be addressed while committing.
Jan
