[Public] > -----Original Message----- > From: Jan Beulich <[email protected]> > Sent: Monday, October 13, 2025 2:41 PM > To: Penny, Zheng <[email protected]> > Cc: Huang, Ray <[email protected]>; Andrew Cooper > <[email protected]>; Anthony PERARD <[email protected]>; > Orzel, Michal <[email protected]>; Julien Grall <[email protected]>; Roger Pau > Monné <[email protected]>; Stefano Stabellini <[email protected]>; > Bertrand Marquis <[email protected]>; Volodymyr Babchuk > <[email protected]>; Tamas K Lengyel <[email protected]>; > Daniel P. Smith <[email protected]>; [email protected] > Subject: Re: [PATCH v2 24/26] xen/domctl: wrap arch-specific domctl-op with > CONFIG_MGMT_HYPERCALLS > > On 11.10.2025 08:44, Penny, Zheng wrote: > >> -----Original Message----- > >> From: Jan Beulich <[email protected]> > >> Sent: Thursday, September 11, 2025 9:03 PM > >> > >>> --- a/xen/lib/x86/Makefile > >>> +++ b/xen/lib/x86/Makefile > >>> @@ -1,3 +1,3 @@ > >>> obj-y += cpuid.o > >>> obj-y += msr.o > >>> -obj-y += policy.o > >>> +obj-$(CONFIG_MGMT_HYPERCALLS) += policy.o > >> > >> Fair parts of cpuid.c also become unreachable. And all of msr.c afaics. > >> > > > > I just found that the functions defined here, as helpers/libraries, are > > used in > tools/libs/guest/xg_cpuid_x86.c too. Emmm, to make compiler happy, I still > need to > provide stubs for them when MGMT_HYPERCALLS=n. Or any better suggestion? > > How does the Makefile change here affect tools/libs/guest/? What would you > need > stubs for there? >
Like Function xc_cpu_policy_is_compatible() in tools/libs/guest/xg_cpuid_x86.c is also using x86_cpu_policies_are_compatible() to do the comparison between host and guest. If making xen/lib/x86/plocy.o guarded by MGMT_HYPERCALLS, we will have "undefined reference " error. Imo, it is not suitable to guard files tools/libs/guest/xg_cpuid_x86.o with MGMT_HYPERCALLS. So it we still want to have the Makefile change here, we need to provide stubs. Or we remove the Makefile change here, as the role of these functions is more of the library, > Jan
