On 13.10.2025 00:19, Petr Beneš wrote: > From: Petr Beneš <[email protected]> > > Match the number format the specification gives. > > No functional change. > > Signed-off-by: Petr Beneš <[email protected]> > Suggested-By: <[email protected]>
Please have tags ordered chronologically, and please also add a proper name. (Also, nit: -by, not -By.) > --- a/tools/firmware/hvmloader/smbios.c > +++ b/tools/firmware/hvmloader/smbios.c > @@ -647,7 +647,7 @@ smbios_type_3_init(void *start) > * which corresponds with the end of the "Security Status" field. > */ > > - BUILD_BUG_ON(endof_field(struct smbios_type_3, security_status) != 13); > + BUILD_BUG_ON(endof_field(struct smbios_type_3, security_status) != 0x0d); As already indicated when these changes were being done within a bigger patch, I don't see a real need for this. It's extra churn for almost no gain. If someone else wants to ack this, I'm not going to stand in the way, but I won't approve it. Pretty certainly there's no justification at all for this to still go into 4.21. Jan
