Re: [PATCH livepatch-build-tools] Treat constant sections as string sections

Ross Lagerwall Mon, 06 Oct 2025 09:50:26 -0700
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">&gt; From:&nbsp;Frediano Ziglio&nbsp;</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">&gt; Sent:&nbsp;Thursday, September 18, 2025 10:51 AM</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">&gt; To:&nbsp;[email protected]&nbsp;</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">&gt; Cc:&nbsp;Frediano Ziglio ; Ross Lagerwall ; Konrad 
Rzeszutek Wilk ; Andrew Cooper ; Roger Pau Monne&nbsp;</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">&gt; Subject:&nbsp;[PATCH livepatch-build-tools] Treat constant 
sections as string sections</div><div class="elementToProof" 
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, 
Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">&gt; 
&nbsp;</div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">&gt; Newer compiler can put some 
constant strings inside constant</div><div class="elementToProof" 
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, 
Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">&gt; sections 
(.rodata.cstXX) instead of string sections (.rodata.str1.XX).</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">&gt; This causes the produced live patch to not apply when 
such</div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">&gt; strings are produced.</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">&gt; So treat the constant sections as string ones.</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);"><br></div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">Are you sure it was a string and not 
something else? As far as I can</div><div class="elementToProof" 
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, 
Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">tell GCC chooses 
the section in categorize_decl_for_section() which</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">doesn't appear to ever put constant strings in 
.rodata.cst.</div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);"><br></div><div class="elementToProof" 
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, 
Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">In any case if we 
have a reference to a constant in .rodata.cst then the</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">section _does_ need to be included in its entirety, though it 
makes me</div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">wonder if is_rodata_str_section is the 
best place for this check.</div><div class="elementToProof" style="font-family: 
Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);"><br></div><div class="elementToProof" 
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, 
Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 
0);">&gt;&nbsp;</div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">&gt; Signed-off-by: Frediano 
Ziglio&nbsp;</div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">&gt; ---</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">&gt; &nbsp;create-diff-object.c | 6 ++++++</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">&gt; &nbsp;1 file changed, 6 insertions(+)</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">&gt;&nbsp;</div><div class="elementToProof" style="font-family: 
Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">&gt; diff --git a/create-diff-object.c 
b/create-diff-object.c</div><div class="elementToProof" style="font-family: 
Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">&gt; index 7e6138b..7acaf88 
100644</div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">&gt; --- 
a/create-diff-object.c</div><div class="elementToProof" style="font-family: 
Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">&gt; +++ 
b/create-diff-object.c</div><div class="elementToProof" style="font-family: 
Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">&gt; @@ -1446,11 +1446,16 @@ static bool 
is_rodata_str_section(const char *name)</div><div class="elementToProof" 
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, 
Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br></div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);">Can you update the comment at the top of this 
function?</div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);"><br></div><div class="elementToProof" 
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, 
Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">&gt; 
&nbsp;{</div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">&gt; &nbsp;#define GCC_5_SECTION_NAME 
".rodata.str1."</div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">&gt; &nbsp;#define GCC_6_SECTION_NAME 
".str1."</div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">&gt; +#define GCC_CSTR 
".rodata.cst"</div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);"><br></div><div class="elementToProof" 
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, 
Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">What does CSTR 
stand for? May call it GCC_CONSTANT_SECTION_NAME instead?</div><div 
class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, 
Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: 
rgb(0, 0, 0);"><br></div><div class="elementToProof" style="font-family: Aptos, 
Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; 
font-size: 12pt; color: rgb(0, 0, 0);">Ross</div>
Re: [PATCH livepatch-build-tools] Treat constant sections as string sections

Reply via email to
