On 07.09.2025 18:15, Bernhard Kaindl wrote: > When domain memory is allocated, domain_adjust_tot_pages(), > also reduces the outstanding claim. > > Replace the checks to not over-reduce the claim beyond 0 > by using min() which prevents the claim to become negative > (and also not be over-conumed for the node and globally)
I'm okay with the code change now, but upon re-reading this it still feels as if this was describing an issue with the original code that is being corrected. Afaict there's no functional change here, and hence the above may want re-wording accordingly. > Cc: Jan Beulich <[email protected]> > Signed-off-by: Bernhard Kaindl <[email protected]> > > --- > Changes: > - Was added as 2/7 in v2, the review by Jan Beulich is applied. This, imo, isn't a useful ChangeLog: It requires readers to go look up the comments on the earlier version. You want to say what has changed; upon what basis the changes were is (again imo) secondary. Jan
