On 10.09.2025 09:38, Penny Zheng wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -1606,10 +1606,12 @@ static int _domain_pause_by_systemcontroller(struct
> domain *d, bool sync)
> return 0;
> }
>
> +#ifdef CONFIG_MGMT_HYPERCALLS
> int domain_pause_by_systemcontroller(struct domain *d)
> {
> return _domain_pause_by_systemcontroller(d, true /* sync */);
> }
> +#endif /* CONFIG_MGMT_HYPERCALLS */
>
> int domain_pause_by_systemcontroller_nosync(struct domain *d)
> {
I would have ack-ed this if there was only this part, but ...
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -390,11 +390,13 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t)
> u_domctl)
> break;
> }
>
> +#ifdef CONFIG_MGMT_HYPERCALLS
> case XEN_DOMCTL_pausedomain:
> ret = -EINVAL;
> if ( d != current->domain )
> ret = domain_pause_by_systemcontroller(d);
> break;
> +#endif /* CONFIG_MGMT_HYPERCALLS */
>
> case XEN_DOMCTL_unpausedomain:
> ret = domain_unpause_by_systemcontroller(d);
... as expressed elsewhere I'm not happy about this one, as it'll need
undoing in a later patch of this same series.
Jan
