Re: [PATCH v6 06/15] emul/ns16x50: implement IER/IIR registers

[dmukhin]

On Fri, Sep 05, 2025 at 06:42:13PM -0700, Stefano Stabellini wrote:
> On Fri, 5 Sep 2025, dmuk...@xen.org wrote:
[..]
> > +static void ns16x50_irq_assert(const struct vuart_ns16x50 *vdev)
> > +{
> > +    struct domain *d = vdev->owner;
> > +    const struct vuart_info *info = vdev->info;
> > +    int vector;
> > +
> > +    if ( has_vpic(d) )
> > +        vector = hvm_isa_irq_assert(d, info->irq, vioapic_get_vector);
> > +    else
> > +        ASSERT_UNREACHABLE();
> 
> This seems dangerous as there are guests without vpic

Agreed; will update.