On 01.09.2025 17:36, Andrew Cooper wrote:
> On 01/09/2025 10:46 am, Jan Beulich wrote:
>> On 28.08.2025 17:03, Andrew Cooper wrote:
>>> FRED provides %cr2 in the the stack frame, avoiding the need to read %cr2
>>> manually.
>>>
>>> Rename do_page_fault() to handle_PF(), and update it to take cr2, still 
>>> named
>>> addr for consistency.
>>>
>>> Introduce a new handle_PF_IDT() which reads %cr2 and conditionally 
>>> re-enables
>>> interrupts.
>> Why does this IRQ-re-enabling move to the IDT-specific function? Do you 
>> intend
>> to do the re-enabling yet earlier in FRED mode?
> 
> It is updated in a common path under FRED.

Right, having spotted it the meantime:
Reviewed-by: Jan Beulich <[email protected]>

Jan

Reply via email to