On 23/07/18 10:09, Roger Pau Monné wrote:
> On Fri, Jul 20, 2018 at 02:15:05PM -0700, Christopher Clark wrote:
>> Exclude named output files from the Xen tree setup.
>>
>> The linkfarm.stamp content will differ between top level "make"
>> and "make install" invocations, due to the introduction of these
>> output files that are produced during the "make" build.
>>
>> Filter these out to prevent an unnecessary rebuild of the shim during
>> "make install".
>>
>> Signed-off-by: Christopher Clark <[email protected]>
>> ---
>>  tools/firmware/xen-dir/Makefile | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/firmware/xen-dir/Makefile 
>> b/tools/firmware/xen-dir/Makefile
>> index 84648c3..e490dca 100644
>> --- a/tools/firmware/xen-dir/Makefile
>> +++ b/tools/firmware/xen-dir/Makefile
>> @@ -11,6 +11,9 @@ D=xen-root
>>  LINK_DIRS=config xen
>>  LINK_FILES=Config.mk
>>  
>> +# Files to exclude from the link farm
>> +EXCLUDE_FILES=xen xen.gz xen-syms xen-syms.map efi.lds xen.lds mkelf32 
>> mkreloc
> I don't really like to list the files here, since it's very easy for
> them to get out of sync. The alternative I have is also not very nice
> however, since it relies on .gitignore:
>
> EXCLUDE_FILES:=$(patsubst xen/%,%,$(filter xen/%,$(shell cat 
> $(XEN_ROOT)/.gitignore)))

The correct way to fix this is to rip the current build system to
shreds, start again, and get it to support out-of-tree builds.

This linkfarm logic exists only to work around a hole which we couldn't
fix at the time.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to