On 28.08.2025 17:03, Andrew Cooper wrote: > FRED doesn't use Supervisor Shadow Stack tokens. Skip setting them up. > > Signed-off-by: Andrew Cooper <[email protected]>
In principle Reviewed-by: Jan Beulich <[email protected]> However, ... > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -1920,10 +1920,6 @@ void asmlinkage __init noreturn __start_xen(void) > > system_state = SYS_STATE_boot; > > - bsp_stack = cpu_alloc_stack(0); > - if ( !bsp_stack ) > - panic("No memory for BSP stack\n"); > - > console_init_ring(); > vesa_init(); > > @@ -2077,6 +2073,10 @@ void asmlinkage __init noreturn __start_xen(void) > > traps_init(); /* Needs stubs allocated. */ > > + bsp_stack = cpu_alloc_stack(0); /* Needs to know IDT vs FRED */ > + if ( !bsp_stack ) > + panic("No memory for BSP stack\n"); ... while this is the earliest possible point now, can we please consider moving it yet further down? E.g. next to the setting of system_state to SYS_STATE_smp_boot, i.e. in particular past IRQ and spin-debug enabling? Jan
