On 21.08.2025 17:25, Teddy Astie wrote: > Make do_xen_version more readable by moving the main XENVER_get_features > into a separate function.
I can't spot much of a readability gain, to be honest. > --- a/xen/common/kernel.c > +++ b/xen/common/kernel.c > @@ -569,6 +569,50 @@ static long xenver_varbuf_op(int cmd, > XEN_GUEST_HANDLE_PARAM(void) arg) > return sz; > } > > +static long xenver_get_features(struct domain *d, uint32_t submap_idx, > uint32_t *submap) Why "long", when you only return "int" -errno values? Speaking of "long", why such long a line? Jan
