Hi Michal,
>> +++ b/xen/arch/arm/include/asm/arm32/mpu.h
>> @@ -39,6 +39,8 @@ typedef union {
>> typedef struct {
>> prbar_t prbar;
>> prlar_t prlar;
>> + bool transient;
> Do we expect to have any other flags? If so, it could make sense to use a
> bitfield right away.
Yes, at least one more flag at present - I will update this to use a bitfield
in the next version of the series.
>> #ifdef CONFIG_ARM_64
>> -#define XEN_MPUMAP_ENTRY_SHIFT 0x4 /* 16 byte structure */
>> +#define XEN_MPUMAP_ENTRY_SHIFT 0x5 /* 32 byte structure */
>> +#define XEN_MPUMAP_ENTRY_ZERO_OFFSET 0x10 /* {PRBAR, PRLAR} is 16 bytes
>> */
> To avoid having to update this over and over again, maybe define a macro using
> OFFSET?
>
> Other than that:
> Reviewed-by: Michal Orzel <[email protected]>
>
> ~Michal
Good point - I will do this in the next version of the series.
Many thanks,
Hari
