On Tue, Aug 26, 2025 at 12:26 PM Julien Grall <[email protected]> wrote: > > Hi Mykola, > > On 26/08/2025 10:09, Mykola Kvach wrote: > >> Shouldn't this be removed so the check also apply for 32-bit domain on > >> 64-bit system? > > > > AFAIK, this question was already addressed in a previous version of > > this patch series: > > https://patchew.org/Xen/[email protected]/072270e0940b6bcc2743d56a336363f4719ba60a.1751020456.git.mykola._5fkv...@epam.com/#[email protected] > > Sure. For 32-bit domain, in theory the top bits should be zeroed. But > AFAIK, there is no harm to zero them again and it would avoid someone to > wonder why this is protected by is_64bit_domain(). > > So unless there is a strong reason to keep, I would rather prefer if we > remove the 64-bit.
Understood, I’ll remove the 64-bit domain check as suggested. > > Cheers, > > -- > Julien Grall > Best Regards, Mykola
