Re: [PATCH] xen/arm: irq: add missing spin_unlock() in init_local_irq_data() error path

[Jan Beulich]

On 09.08.2025 16:32, Mykola Kvach wrote:
> From: Mykola Kvach <mykola_kv...@epam.com>
> 
> If init_one_irq_desc() fails, init_local_irq_data() returns without
> releasing local_irqs_type_lock, leading to a possible deadlock.
> 
> Release the lock before returning to ensure proper cleanup.
> 
> Signed-off-by: Mykola Kvach <mykola_kv...@epam.com>

Pretty likely wants backporting, which would best be indicated by a suitable
Fixes: tag.

Jan

> --- a/xen/arch/arm/irq.c
> +++ b/xen/arch/arm/irq.c
> @@ -94,7 +94,10 @@ static int init_local_irq_data(unsigned int cpu)
>          int rc = init_one_irq_desc(desc);
>  
>          if ( rc )
> +        {
> +            spin_unlock(&local_irqs_type_lock);
>              return rc;
> +        }
>  
>          desc->irq = irq;
>          desc->action  = NULL;