On 11.08.2025 06:04, Chen, Jiqian wrote:
> On 2025/8/8 16:58, Jan Beulich wrote:
>> On 08.08.2025 10:03, Jiqian Chen wrote:
>>> @@ -321,6 +321,29 @@ void vpci_deassign_device(struct pci_dev *pdev)
>>> &pdev->domain->vpci_dev_assigned_map);
>>> #endif
>>>
>>> + for ( i = 0; i < NUM_VPCI_INIT; i++ )
>>> + {
>>> + const vpci_capability_t *capability = &__start_vpci_array[i];
>>> + const unsigned int cap = capability->id;
>>> + unsigned int pos = 0;
>>> +
>>> + if ( !capability->cleanup )
>>> + continue;
>>> +
>>> + if ( !capability->is_ext )
>>> + pos = pci_find_cap_offset(pdev->sbdf, cap);
>>> + else if ( is_hardware_domain(pdev->domain) )
>>> + pos = pci_find_ext_capability(pdev->sbdf, cap);
>>> + if ( pos )
>>> + {
>>> + int rc = capability->cleanup(pdev, false);
>>> + if ( rc )
>>
>> Nit: Blank line between declaration(s) and statement(s) please. (Likely
>> easy enough to adjust while committing, if no other need for a v12
>> arises.)
> Thanks.
> BTW, do I need for-4.21 flag if I expect this series to be merged before 4.21
> release?
I wouldn't say "need", but adding such a tag may now be advisable.
Jan
