[Public] > -----Original Message----- > From: Jan Beulich <[email protected]> > Sent: Monday, August 4, 2025 3:43 PM > To: Penny, Zheng <[email protected]> > Cc: Huang, Ray <[email protected]>; Andrew Cooper > <[email protected]>; Roger Pau Monné <[email protected]>; > Anthony PERARD <[email protected]>; Orzel, Michal > <[email protected]>; Julien Grall <[email protected]>; Stefano Stabellini > <[email protected]>; [email protected] > Subject: Re: [PATCH v1 01/25] xen/x86: move domctl.o out of > PV_SHIM_EXCLUSIVE > > On 03.08.2025 11:47, Penny Zheng wrote: > > In order to fix CI error of a randconfig picking both > > PV_SHIM_EXCLUSIVE=y and HVM=y results in hvm.c being built, but > > domctl.c not being built, which leaves a few functions, like > > domctl_lock_acquire/release() undefined, causing linking to fail. > > To fix that, we intend to move domctl.o out of the PV_SHIM_EXCLUSIVE > > Makefile /hypercall-defs section, with this adjustment, we also need > > to release redundant vnuma_destroy() stub definition and paging_domctl > > hypercall-defs from PV_SHIM_EXCLUSIVE guardian, to not break > > compilation Above change will leave dead code in the shim binary > > temporarily and will be fixed with the introduction of CONFIG_DOMCTL. > > > > Fixes: 568f806cba4c ("xen/x86: remove "depends on > > !PV_SHIM_EXCLUSIVE"") > > Reported-by: Jan Beulich <[email protected]> > > Signed-off-by: Penny Zheng <[email protected]> > > --- > > v1 -> v2: > > - remove paging_domctl hypercall-defs > > And you've run this through a full round of testing this time, in isolation? >
This commit shall be committed together with "xen/x86: complement PG_log_dirty wrapping", (I've added in change log, idk why it didn't get delivered in the mail list in the last). As PG_log_dirty is disabled on PV mode, paging_domctl() will still have "undefined reference" on PV mode, which gets fixed in "xen/x86: complement PG_log_dirty wrapping". I thought it better sits there. If it doesn't comply with the commit policy, I'll move according fix here. > Jan
