On 12.06.2025 11:29, Jiqian Chen wrote:
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -83,6 +83,88 @@ static int assign_virtual_sbdf(struct pci_dev *pdev)
>
> #endif /* CONFIG_HAS_VPCI_GUEST_SUPPORT */
>
> +static struct vpci_register *vpci_get_register(struct vpci *vpci,
Actually, even here (and then in all callers) the question arises why this
isn't pointer-to-const. I realize ...
> + unsigned int offset,
> + unsigned int size)
> +{
> + struct vpci_register *r;
... this one may not want to be, as long as the function is required to
return pointer-to-non-const (assuming that property is actually required
anywhere).
Jan
