From: Nicola Vetrini <[email protected]> Function `reboot_machine' does not return, but lacks the `noreturn' attribute.
Functions that never return should be declared with a `noreturn' attribute. The lack of `noreturn' causes a violation of MISRA C Rule 17.11 (not currently accepted in Xen), and also Rule 2.1: "A project shall not contain unreachable code". Depending on the compiler used and the compiler optimization used, the lack of `noreturn' might lead to the presence of unreachable code. No functional change. Signed-off-by: Nicola Vetrini <[email protected]> Signed-off-by: Victor Lira <[email protected]> --- Changes in v2: - improved commit message --- Cc: Andrew Cooper <[email protected]> Cc: Anthony PERARD <[email protected]> Cc: Michal Orzel <[email protected]> Cc: Jan Beulich <[email protected]> Cc: Julien Grall <[email protected]> Cc: Roger Pau Monné <[email protected]> Cc: Stefano Stabellini <[email protected]> Cc: Nicola Vetrini <[email protected]> Cc: Federico Serafini <[email protected]> Cc: Bertrand Marquis <[email protected]> --- xen/common/keyhandler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c index 0bb842ec00..b0a2051408 100644 --- a/xen/common/keyhandler.c +++ b/xen/common/keyhandler.c @@ -251,7 +251,7 @@ static void cf_check dump_hwdom_registers(unsigned char key) } } -static void cf_check reboot_machine(unsigned char key, bool unused) +static void noreturn cf_check reboot_machine(unsigned char key, bool unused) { printk("'%c' pressed -> rebooting machine\n", key); machine_restart(0); -- 2.25.1
