On 28.05.2025 10:05, Mykola Kvach wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -33,6 +33,8 @@ config X86 > select HAS_VMAP > select HAS_VPCI if HVM > select NEEDS_LIBELF > + select HAS_SYSTEM_SUSPEND > + select SYSTEM_SUSPEND_ALWAYS_ON
To avoid other architectures potentially also needing to select both, how about moving the former one ... > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -579,4 +579,21 @@ config BUDDY_ALLOCATOR_SIZE > Amount of memory reserved for the buddy allocator to serve Xen heap, > working alongside the colored one. > > +config HAS_SYSTEM_SUSPEND > + bool > + > +config SYSTEM_SUSPEND_ALWAYS_ON > + bool ... here? > +config SYSTEM_SUSPEND > + bool "System suspend support" > + depends on HAS_SYSTEM_SUSPEND > + default y if SYSTEM_SUSPEND_ALWAYS_ON Hmm, this way "always on" isn't achieved. Someone can still turn it off, likely causing the build to fail (until it is properly made an optional feature). You also need to make the prompt invisible (by attaching "if SYSTEM_SUSPEND_ALWAYS_ON"). Also the default line could be shorter as "default SYSTEM_SUSPEND_ALWAYS_ON"; aiui with modern kconfig there's no difference anymore between the two. Jan
