On Tue, 3 Jun 2025, Andrew Cooper wrote: > On 03/06/2025 1:42 pm, Anthony PERARD wrote: > > diff --git a/automation/scripts/run-tools-tests > > b/automation/scripts/run-tools-tests > > index 695ed77e46..852c1cfbcf 100755 > > --- a/automation/scripts/run-tools-tests > > +++ b/automation/scripts/run-tools-tests > > @@ -25,9 +25,9 @@ for f in "$1"/*; do > > echo "FAILED: $f" > > failed+=" $f" > > printf ' <failure type="failure" message="binary %s exited with > > code %d">\n' "$f" "$ret" >> "$xml_out" > > - # TODO: could use xml escaping... but current tests seems to > > - # produce sane output > > + printf '<![CDATA[' >> "$xml_out" > > cat /tmp/out >> "$xml_out" > > + printf ']]>' >> "$xml_out" > > I think you want a \n on this printf. > > I'd also suggest leaving a TODO for "escape ]]> if necessary". > > Otherwise, Reviewed-by: Andrew Cooper <[email protected]>
Acked-by: Stefano Stabellini <[email protected]>
