On 31.05.2025 03:47, Stefano Stabellini wrote:
> On Fri, 30 May 2025, Alejandro Vallejo wrote:
>> --- /dev/null
>> +++ b/xen/common/device-tree/bootfdt.c
>> @@ -0,0 +1,97 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +#include <xen/bootfdt.h>
>> +#include <xen/bug.h>
>> +#include <xen/lib.h>
>> +#include <xen/libfdt/libfdt.h>
>> +
>> +uint32_t __init device_tree_get_u32(const void *fdt, int node,
>> + const char *prop_name, uint32_t dflt)
>> +{
>> + const struct fdt_property *prop;
>> +
>> + prop = fdt_get_property(fdt, node, prop_name, NULL);
>> + if ( !prop || prop->len < sizeof(u32) )
>
> Ah this is where the u32->uint32_t renaming is done!
> Since we are at it, we can change the u32 in the sizeof
>
>
>> + return dflt;
>> +
>> + return fdt32_to_cpu(*(uint32_t*)prop->data);
And avoid to cast away const-ness here.
Jan
