Hello, This is adjusting some MISRA configuration. I'm reasonably sure the change is fine as we're simply removing the referenced helper, but can we get a second opinion from anyone who knows what function-macro-properties.json is supposed to be doing?
Thanks, ~Andrew On 13/05/2025 6:28 am, [email protected] wrote: > From: Denis Mukhin <[email protected]> > > Remove __vmread() and adjust ECLAIR configuration to account for the change. > > Signed-off-by: Denis Mukhin <[email protected]> > --- > docs/misra/function-macro-properties.json | 9 --------- > xen/arch/x86/include/asm/hvm/vmx/vmx.h | 5 ----- > 2 files changed, 14 deletions(-) > > diff --git a/docs/misra/function-macro-properties.json > b/docs/misra/function-macro-properties.json > index 74058297b5..59ba63626e 100644 > --- a/docs/misra/function-macro-properties.json > +++ b/docs/misra/function-macro-properties.json > @@ -152,15 +152,6 @@ > "taken": "" > } > }, > - { > - "type": "function", > - "value": "^__vmread.*$", > - "properties":{ > - "pointee_write": "2=always", > - "pointee_read": "2=never", > - "taken": "" > - } > - }, > { > "type": "function", > "value": "^hvm_pci_decode_addr.*$", > diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h > b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > index d85b52b9d5..299e2eff6b 100644 > --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h > +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > @@ -336,11 +336,6 @@ static always_inline unsigned long vmread(unsigned long > field) > return value; > } > > -static always_inline void __vmread(unsigned long field, unsigned long *value) > -{ > - *value = vmread(field); > -} > - > static always_inline void __vmwrite(unsigned long field, unsigned long value) > { > asm goto ( "vmwrite %[value], %[field]\n\t"
