On 13.05.2025 19:18, Stewart Hildebrand wrote:
> --- a/xen/common/device-tree/dom0less-build.c
> +++ b/xen/common/device-tree/dom0less-build.c
> @@ -730,8 +730,8 @@ static int __init domain_p2m_set_allocation(struct domain
> *d, uint64_t mem,
> return rc;
> }
> #else /* !CONFIG_ARCH_PAGING_MEMPOOL */
> -static inline int domain_p2m_set_allocation(struct domain *d, uint64_t mem,
> - const struct dt_device_node
> *node)
> +static inline int __init domain_p2m_set_allocation(
> + struct domain *d, uint64_t mem, const struct dt_device_node *node)
> {
> return 0;
> }
Imo the better fix would be to move the #ifdef into the body of a
function. That would then also get rid of the stray "inline", which
generally we want only in header files. For a (stub) function like
this one inlining should be left entirely to the discretion of the
compiler.
Jan
