[Public] Hi,
> -----Original Message----- > From: Jan Beulich <[email protected]> > Sent: Wednesday, April 30, 2025 12:39 AM > To: Penny, Zheng <[email protected]> > Cc: Huang, Ray <[email protected]>; Andrew Cooper > <[email protected]>; Anthony PERARD <[email protected]>; > Orzel, Michal <[email protected]>; Julien Grall <[email protected]>; Roger > Pau Monné <[email protected]>; Stefano Stabellini <[email protected]>; > [email protected] > Subject: Re: [PATCH v4 11/15] xen/x86: implement EPP support for the amd-cppc > driver in active mode > > On 14.04.2025 09:40, Penny Zheng wrote: > > @@ -434,12 +464,82 @@ static int cf_check > > amd_cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) > > > > amd_cppc_boost_init(policy, data); > > > > + return 0; > > +} > > + > > +static int cf_check amd_cppc_cpufreq_cpu_init(struct cpufreq_policy > > +*policy) { > > + int ret; > > + > > + ret = amd_cppc_cpufreq_init_perf(policy); > > + if ( ret ) > > + return ret; > > + > > amd_cppc_verbose(policy->cpu, > > "CPU initialized with amd-cppc passive mode\n"); > > > > return 0; > > } > > > > +static int cf_check amd_cppc_epp_cpu_init(struct cpufreq_policy > > +*policy) { > > + int ret; > > + > > + ret = amd_cppc_cpufreq_init_perf(policy); > > + if ( ret ) > > + return ret; > > + > > + policy->policy = cpufreq_policy_from_governor(policy->governor); > > This is the init part, which is fine. What if the governor is being changed, > though? > The struct field is new, and there's no other place I can spot where it would > be > adjusted. > Yes, I've missed the part that user changing governor through "xenpm set-scaling-governor" I'll add a new commit to fix > > Jan
