Re: [PATCH 1/6] xen/arm: fix math in add_ext_regions

[Orzel, Michal]

On 05/05/2025 04:56, Stewart Hildebrand wrote:
> In commit f37a59813979, the arguments to add_ext_regions() were switched
> from addresses to frame numbers. add_ext_regions() converts the frame
> numbers back to addresses, but the end address (e) is rounded down to
> page size alignment. The logic to calculate the size assumes e points to
> the last address, not page, effectively leading to the region size being
> erroneously calculated to be 2M smaller than the actual size of the
> region.
> 
> Fix by adding 1 to the frame number before converting back to address.
> 
> Fixes: f37a59813979 ("xen/arm: domain_build: Track unallocated pages using 
> the frame number")
> Signed-off-by: Stewart Hildebrand <stewart.hildebr...@amd.com>
Acked-by: Michal Orzel <michal.or...@amd.com>

~Michal